refactor: clean up invalid log tags (#426) - #684
Conversation
|
@prince-0408, would you be able to take a look? Thanks so much for the PR, @akkicodes-dev! |
@andrewtavis Sure! on it! |
|
LGTM! Reviewed the changes across all 3 files:
Thanks @akkicodes-dev! |
|
Discussing this with @angrezichatterbox right now, we're wondering what the use would be for keeping these logs at all. It might be nice to have an audit of the current logs that we have and whether they're useful for the development process :) |
|
Thanks @prince-0408! And that's a great point @andrewtavis — happy to help with a logs audit if that would be useful. For now, should I proceed with this PR as-is since it fixes the immediate issues (invalid/typo'd/clashing tags), or would you prefer to hold off until the broader audit discussion concludes? |
|
Hey @akkicodes-dev Thanks : ) |
|
Thanks @angrezichatterbox! Yes, I'd be happy to take this on To scope it correctly, a couple of quick questions:
I'll start going through it and share my findings soon! |
|
Completed the log audit! Went through all Log.* calls in the codebase (76 total across app/src/main and app/src/keyboards). Summary:
Here are the 7 candidates for removal:
Want me to open a follow-up PR removing these 7, or would you like to review first? |
Summary
Cleans up invalid, typo'd, and generic log tags identified as part of #426.
Changes
KeyboardBase.kt: Replaced invalid unicode symbol tag"≠"with properTAGconstant ("KeyboardBase")KeyboardView.kt: Fixed typo'd tag"Souncheck"→TAGconstant ("SoundCheck")LanguageSettingsScreen.kt: Replaced generic, clashing"Navigation"tag (used in 3 places) with specificTAGconstant ("LanguageSettingsScreen")Testing
./gradlew lintKotlin detekt— passed, no issues./gradlew test— all tests passedNote
Parts of this PR were AI-assisted (Antigravity); all changes were manually reviewed line-by-line, verified via local build/lint/test, and tested on a physical device before submission.
Part of #426.